diff --git a/lib/gitlab/email/receiver.rb b/lib/gitlab/email/receiver.rb index d67e96ff139780ef9268f36ad7469a7c4c49292c..b8065580b54139c49a7e167d99eba3e8c8d2f12a 100644 --- a/lib/gitlab/email/receiver.rb +++ b/lib/gitlab/email/receiver.rb @@ -40,7 +40,7 @@ module Gitlab author = sent_notification.recipient project = sent_notification.project - validate_permission(author, project, :create_note) + validate_permission!(author, project, :create_note) raise NoteableNotFoundError unless sent_notification.noteable @@ -59,7 +59,7 @@ module Gitlab end def process_create_issue - validate_permission(message_sender, message_project, :create_issue) + validate_permission!(message_sender, message_project, :create_issue) issue = Issues::CreateService.new( message_project, @@ -78,7 +78,7 @@ module Gitlab end end - def validate_permission(author, project, permission) + def validate_permission!(author, project, permission) raise UserNotFoundError unless author raise UserBlockedError if author.blocked? # TODO: Give project not found error if author cannot read project