Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Boxiang Sun
gitlab-ce
Commits
a11b2304
Commit
a11b2304
authored
Feb 07, 2017
by
Kushal Pandya
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use `gl.utils.isMetaClick` to identify meta-clicks
parent
936f463b
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
10 deletions
+2
-10
app/assets/javascripts/merge_request_tabs.js.es6
app/assets/javascripts/merge_request_tabs.js.es6
+1
-5
app/assets/javascripts/todos.js.es6
app/assets/javascripts/todos.js.es6
+1
-5
No files found.
app/assets/javascripts/merge_request_tabs.js.es6
View file @
a11b2304
...
@@ -104,11 +104,7 @@ require('./flash');
...
@@ -104,11 +104,7 @@ require('./flash');
clickTab(e) {
clickTab(e) {
if (e.target) {
if (e.target) {
const targetLink = e.target.getAttribute('href');
const targetLink = e.target.getAttribute('href');
// Allow following special clicks to make link open in new tab
if (gl.utils.isMetaClick(e)) {
// 1) Cmd + Click on Mac (e.metaKey)
// 2) Ctrl + Click on PC (e.ctrlKey)
// 3) Middle-click or Mouse Wheel Click (e.which is 2)
if (e.metaKey || e.ctrlKey || e.which === 2) {
e.stopImmediatePropagation();
e.stopImmediatePropagation();
window.open(targetLink, '_blank');
window.open(targetLink, '_blank');
}
}
...
...
app/assets/javascripts/todos.js.es6
View file @
a11b2304
...
@@ -157,11 +157,7 @@
...
@@ -157,11 +157,7 @@
return;
return;
}
}
// Allow following special clicks to make link open in new tab
if (gl.utils.isMetaClick(e)) {
// 1) Cmd + Click on Mac (e.metaKey)
// 2) Ctrl + Click on PC (e.ctrlKey)
// 3) Middle-click or Mouse Wheel Click (e.which is 2)
if (e.metaKey || e.ctrlKey || e.which === 2) {
e.preventDefault();
e.preventDefault();
// Meta-Click on username leads to different URL than todoLink.
// Meta-Click on username leads to different URL than todoLink.
// Turbolinks can resolve that URL, but window.open requires URL manually.
// Turbolinks can resolve that URL, but window.open requires URL manually.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment