diff --git a/product/ERP5/mixin/rule.py b/product/ERP5/mixin/rule.py index 6b7322f43dcb3e780cfef703a9f92d6ef8818f8b..502c93ad607f88b9a5f1f3664f92d128091fa55e 100644 --- a/product/ERP5/mixin/rule.py +++ b/product/ERP5/mixin/rule.py @@ -120,9 +120,10 @@ class MovementGeneratorMixin: return result def _getUpdatePropertyDict(self, input_movement): - # Default implementation bellow can be overriden by subclasses - return {'delivery': input_movement.getRelativeUrl(), # XXX-JPS empty is better - } + # XXX Wouldn't it better to return {} or {'delivery': None} ? + # Below code is mainly for root applied rules. + # Other movement generators usually want to reset delivery. + return {'delivery': input_movement.getRelativeUrl()} def _getTradePhaseList(self, input_movement, business_process): # XXX-JPS WEIRD movement_trade_phase = input_movement.getTradePhaseList()