From 3c1db12ca23c179272b934f573ae202aeee849d4 Mon Sep 17 00:00:00 2001 From: Julien Muchembled <jm@nexedi.com> Date: Fri, 6 Aug 2010 18:38:38 +0000 Subject: [PATCH] Clarify MovementGeneratorMixin._getUpdatePropertyDict git-svn-id: https://svn.erp5.org/repos/public/erp5/sandbox/amount_generator@37611 20353a03-c40f-0410-a6d1-a30d3c3de9de --- product/ERP5/mixin/rule.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/product/ERP5/mixin/rule.py b/product/ERP5/mixin/rule.py index 6b7322f43d..502c93ad60 100644 --- a/product/ERP5/mixin/rule.py +++ b/product/ERP5/mixin/rule.py @@ -120,9 +120,10 @@ class MovementGeneratorMixin: return result def _getUpdatePropertyDict(self, input_movement): - # Default implementation bellow can be overriden by subclasses - return {'delivery': input_movement.getRelativeUrl(), # XXX-JPS empty is better - } + # XXX Wouldn't it better to return {} or {'delivery': None} ? + # Below code is mainly for root applied rules. + # Other movement generators usually want to reset delivery. + return {'delivery': input_movement.getRelativeUrl()} def _getTradePhaseList(self, input_movement, business_process): # XXX-JPS WEIRD movement_trade_phase = input_movement.getTradePhaseList() -- 2.30.9