From a0ee2634e877c16c06def35c0740e7c8b6e32837 Mon Sep 17 00:00:00 2001 From: Tatuya Kamada <tatuya@nexedi.com> Date: Fri, 28 Oct 2011 16:14:21 +0900 Subject: [PATCH] We should catch an exception explicitly. See Coding Crime Guideline. http://www.erp5.org/GuidelinesForCodingCrimes (thx nicolas) --- product/ERP5/Document/Resource.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/product/ERP5/Document/Resource.py b/product/ERP5/Document/Resource.py index 212d86f62a..d3e3fd454f 100644 --- a/product/ERP5/Document/Resource.py +++ b/product/ERP5/Document/Resource.py @@ -1136,9 +1136,9 @@ class Resource(XMLObject, XMLMatrix, VariatedMixin): resource_uid=self.getUid()) try: return query[0].quantity - except: - raise LookupError('Can not find the Quantity Unit Conversion '\ - 'Definition. Please make sure that Unit '\ - 'Conversion Definitions are indexed.'\ - 'quantity_unit_uid: %s, resource_uid: %s' \ - % (quantity_unit_uid, self.getUid())) + except IndexError: + raise IndexError('Can not find the Quantity Unit Conversion '\ + 'Definition. Please make sure that Unit '\ + 'Conversion Definitions are indexed and validated. '\ + 'quantity_unit_uid: %s, resource_uid: %s' \ + % (quantity_unit_uid, self.getUid())) -- 2.30.9