From f317ba573a8f3e2dc5c31a0ecfe3540723f58fa0 Mon Sep 17 00:00:00 2001
From: Nicolas Dumazet <nicolas.dumazet@nexedi.com>
Date: Mon, 15 Mar 2010 02:50:28 +0000
Subject: [PATCH] add remark about limitations of consistency implementation in
 XMLMatrix

git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@33705 20353a03-c40f-0410-a6d1-a30d3c3de9de
---
 product/ERP5Type/XMLMatrix.py | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/product/ERP5Type/XMLMatrix.py b/product/ERP5Type/XMLMatrix.py
index fa69254aa6..53a75cab50 100644
--- a/product/ERP5Type/XMLMatrix.py
+++ b/product/ERP5Type/XMLMatrix.py
@@ -621,6 +621,14 @@ class XMLMatrix(Folder):
       if getattr(aq_base(self), 'index', None) is None:
         self.index = PersistentMapping()
       # We will check each cell of the matrix the matrix
+
+      # XXX This code assumes the following predicate:
+      #   each subobject of an XMLMatrix is either a Cell that needs
+      #   consistency checking OR ( is not a Cell, and has an id that is
+      #   not like "(\w+_)+(\d+_)*\d+" )
+      # But Documents inheriting XMLMatrix can have unrelated, non-cell
+      # subobjects, possibly with id looking like some_id_2. If it ever happens,
+      # an error will be wrongly raised.
       for obj in self.objectValues():
         object_id = obj.getId()
         # obect_id is equal to something like 'something_quantity_3_2'
-- 
2.30.9