.

bigfile/file_zodb.py

@@ -755,7 +755,7 @@ Connection.open = Connection_open
 class _ZBigFileH(object):
     # .zfile        ZBigFile we were opened for
     # .wcfileh      handle for ZBigFile in wcfs | None
-    # .zfileh       handle for ZBigFile (overlayed over .wcfileh if .wcfileh != ø)
+    # .zfileh       handle for ZBigFile in virtmem (overlayed over .wcfileh if .wcfileh != ø)
 
     def __init__(self, zfile, wcfileh):
         self.zfile   = zfile

bigfile/virtmem.c

@@ -162,6 +162,7 @@ int fileh_open(BigFileH *fileh, BigFile *file, RAM *ram, FileHOpenFlags flags)
     if (flags == MMAP_OVERLAY) {
         ASSERT(fops->mmap_setup_read);
         ASSERT(fops->remmap_blk_read);
+	// XXX assert fops->munmap
     }
     if (flags == DONT_MMAP_OVERLAY) {
         ASSERT(fops->loadblk);

include/wendelin/bigfile/file.h

@@ -58,7 +58,6 @@ struct bigfile_ops {
     /* loadblk is called to load file block into memory.
      *
      * NOTE loadblk is called from SIGSEGV signal handler context.
-     * XXX loadblk -> !mmap_read ?
      *
      * len(buf) must be = file->blksize.
      * @return  0 - ok      !0 - fail
@@ -102,7 +101,6 @@ struct bigfile_ops {
      *
      * XXX called under virtmem lock?
      *
-     * XXX mmap_read -> !loadblk ?
      * NOTE blk and blklen are in blocks, not pages.
      *
      * @addr    NULL - mmap at anywhere,    !NULL - mmap exactly at addr.   XXX