From e73a69686beb4a5ddfabbbfe8d0ab48c3b0f7ecc Mon Sep 17 00:00:00 2001 From: Jim Fulton <jim@zope.com> Date: Fri, 19 Dec 2008 15:05:26 +0000 Subject: [PATCH] Removed unused berkeley storage tests. Removed test levels. Test levels are an invitation to inadvertently not run tests. --- src/ZEO/tests/testConnection.py | 46 ++------------------------------- 1 file changed, 2 insertions(+), 44 deletions(-) diff --git a/src/ZEO/tests/testConnection.py b/src/ZEO/tests/testConnection.py index f5fc4dbb..486546aa 100644 --- a/src/ZEO/tests/testConnection.py +++ b/src/ZEO/tests/testConnection.py @@ -35,14 +35,6 @@ class FileStorageConfig: create and 'yes' or 'no', read_only and 'yes' or 'no') -class BerkeleyStorageConfig: - def getConfig(self, path, create, read_only): - return """\ - <fullstorage 1> - envdir %s - read-only %s - </fullstorage>""" % (path, read_only and "yes" or "no") - class MappingStorageConfig: def getConfig(self, path, create, read_only): return """<mappingstorage 1/>""" @@ -54,7 +46,6 @@ class FileStorageConnectionTests( InvalidationTests.InvalidationTests ): """FileStorage-specific connection tests.""" - level = 2 class FileStorageReconnectionTests( FileStorageConfig, @@ -62,48 +53,18 @@ class FileStorageReconnectionTests( ): """FileStorage-specific re-connection tests.""" # Run this at level 1 because MappingStorage can't do reconnection tests - level = 1 class FileStorageInvqTests( FileStorageConfig, ConnectionTests.InvqTests ): """FileStorage-specific invalidation queue tests.""" - level = 1 class FileStorageTimeoutTests( FileStorageConfig, ConnectionTests.TimeoutTests ): - level = 2 - -class BDBConnectionTests( - BerkeleyStorageConfig, - ConnectionTests.ConnectionTests, - InvalidationTests.InvalidationTests - ): - """Berkeley storage connection tests.""" - level = 2 - -class BDBReconnectionTests( - BerkeleyStorageConfig, - ConnectionTests.ReconnectionTests - ): - """Berkeley storage re-connection tests.""" - level = 2 - -class BDBInvqTests( - BerkeleyStorageConfig, - ConnectionTests.InvqTests - ): - """Berkeley storage invalidation queue tests.""" - level = 2 - -class BDBTimeoutTests( - BerkeleyStorageConfig, - ConnectionTests.TimeoutTests - ): - level = 2 + pass class MappingStorageConnectionTests( @@ -111,7 +72,6 @@ class MappingStorageConnectionTests( ConnectionTests.ConnectionTests ): """Mapping storage connection tests.""" - level = 1 # The ReconnectionTests can't work with MappingStorage because it's only an # in-memory storage and has no persistent state. @@ -120,10 +80,8 @@ class MappingStorageTimeoutTests( MappingStorageConfig, ConnectionTests.TimeoutTests ): - level = 1 - + pass - test_classes = [FileStorageConnectionTests, FileStorageReconnectionTests, FileStorageInvqTests, -- 2.30.9