Commit 3a4f9671 authored by Mark Dickinson's avatar Mark Dickinson

Issue #9128: Fix validation of class decorators in parser module.

parent f66d4e09
...@@ -156,6 +156,14 @@ class RoundtripLegalSyntaxTestCase(unittest.TestCase): ...@@ -156,6 +156,14 @@ class RoundtripLegalSyntaxTestCase(unittest.TestCase):
def test_class_defs(self): def test_class_defs(self):
self.check_suite("class foo():pass") self.check_suite("class foo():pass")
self.check_suite("@class_decorator\n"
"class foo():pass")
self.check_suite("@class_decorator(arg)\n"
"class foo():pass")
self.check_suite("@decorator1\n"
"@decorator2\n"
"class foo():pass")
def test_import_from_statement(self): def test_import_from_statement(self):
self.check_suite("from sys.path import *") self.check_suite("from sys.path import *")
......
...@@ -81,6 +81,8 @@ C-API ...@@ -81,6 +81,8 @@ C-API
Library Library
------- -------
- Issue #9128: Fix validation of class decorators in parser module.
- Issue #7673: Fix security vulnerability (CVE-2010-2089) in the audioop - Issue #7673: Fix security vulnerability (CVE-2010-2089) in the audioop
module, ensure that the input string length is a multiple of the frame size module, ensure that the input string length is a multiple of the frame size
......
...@@ -2682,10 +2682,11 @@ validate_decorated(node *tree) ...@@ -2682,10 +2682,11 @@ validate_decorated(node *tree)
int nch = NCH(tree); int nch = NCH(tree);
int ok = (validate_ntype(tree, decorated) int ok = (validate_ntype(tree, decorated)
&& (nch == 2) && (nch == 2)
&& validate_decorators(RCHILD(tree, -2)) && validate_decorators(RCHILD(tree, -2)));
&& (validate_funcdef(RCHILD(tree, -1)) if (TYPE(RCHILD(tree, -1)) == funcdef)
|| validate_class(RCHILD(tree, -1))) ok = ok && validate_funcdef(RCHILD(tree, -1));
); else
ok = ok && validate_class(RCHILD(tree, -1));
return ok; return ok;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment