Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
3ad1200e
Commit
3ad1200e
authored
Oct 17, 2016
by
Victor Stinner
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Issue #28409: regrtest: fix the parser of command line arguments.
parent
82e1c08a
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
21 additions
and
6 deletions
+21
-6
Lib/test/regrtest.py
Lib/test/regrtest.py
+7
-4
Lib/test/test_regrtest.py
Lib/test/test_regrtest.py
+10
-0
Misc/NEWS
Misc/NEWS
+4
-2
No files found.
Lib/test/regrtest.py
View file @
3ad1200e
...
...
@@ -325,9 +325,6 @@ def _create_parser():
group
.
add_argument
(
'-P'
,
'--pgo'
,
dest
=
'pgo'
,
action
=
'store_true'
,
help
=
'enable Profile Guided Optimization training'
)
parser
.
add_argument
(
'args'
,
nargs
=
'*'
,
help
=
argparse
.
SUPPRESS
)
return
parser
def
relative_filename
(
string
):
...
...
@@ -373,7 +370,13 @@ def _parse_args(args, **kwargs):
ns
.
use_resources
=
[]
parser
=
_create_parser
()
parser
.
parse_args
(
args
=
args
,
namespace
=
ns
)
# Issue #14191: argparse doesn't support "intermixed" positional and
# optional arguments. Use parse_known_args() as workaround.
ns
.
args
=
parser
.
parse_known_args
(
args
=
args
,
namespace
=
ns
)[
1
]
for
arg
in
ns
.
args
:
if
arg
.
startswith
(
'-'
):
parser
.
error
(
"unrecognized arguments: %s"
%
arg
)
sys
.
exit
(
1
)
if
ns
.
single
and
ns
.
fromfile
:
parser
.
error
(
"-s and -f don't go together!"
)
...
...
Lib/test/test_regrtest.py
View file @
3ad1200e
...
...
@@ -270,6 +270,16 @@ class ParseArgsTestCase(unittest.TestCase):
self
.
assertEqual
(
ns
.
verbose
,
0
)
self
.
assertEqual
(
ns
.
args
,
[
'foo'
])
def
test_arg_option_arg
(
self
):
ns
=
regrtest
.
_parse_args
([
'test_unaryop'
,
'-v'
,
'test_binop'
])
self
.
assertEqual
(
ns
.
verbose
,
1
)
self
.
assertEqual
(
ns
.
args
,
[
'test_unaryop'
,
'test_binop'
])
def
test_unknown_option
(
self
):
self
.
checkError
([
'--unknown-option'
],
'unrecognized arguments: --unknown-option'
)
if
__name__
==
'__main__'
:
unittest
.
main
()
Misc/NEWS
View file @
3ad1200e
...
...
@@ -376,11 +376,11 @@ Library
- Issue #27759: Fix selectors incorrectly retain invalid file descriptors.
Patch by Mark Williams.
- Issue #28368: Refuse monitoring processes if the child watcher has
- Issue #28368: Refuse monitoring processes if the child watcher has
no loop attached.
Patch by Vincent Michel.
- Issue #28369: Raise RuntimeError when transport'
s
FD
is
used
with
- Issue #28369: Raise RuntimeError when transport'
s
FD
is
used
with
add_reader
,
add_writer
,
etc
.
-
Issue
#
28370
:
Speedup
asyncio
.
StreamReader
.
readexactly
.
...
...
@@ -432,6 +432,8 @@ C API
Tests
-----
-
Issue
#
28409
:
regrtest
:
fix
the
parser
of
command
line
arguments
.
-
Issue
#
27787
:
Call
gc
.
collect
()
before
checking
each
test
for
"dangling
threads"
,
since
the
dangling
threads
are
weak
references
.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment