Commit 77f3c871 authored by Raymond Hettinger's avatar Raymond Hettinger

Apply map/zip pre-sizing optimization to a broader class of objects.

Formerly, the length was only fetched from sequence objects.
Now, any object that reports its length can benefit from pre-sizing.
parent 7832cd61
...@@ -791,17 +791,13 @@ builtin_map(PyObject *self, PyObject *args) ...@@ -791,17 +791,13 @@ builtin_map(PyObject *self, PyObject *args)
} }
/* Update len. */ /* Update len. */
curlen = -1; /* unknown */ curlen = PyObject_Size(curseq);
if (PySequence_Check(curseq) && if (curlen < 0) {
curseq->ob_type->tp_as_sequence->sq_length) { PyErr_Clear();
curlen = PySequence_Size(curseq);
if (curlen < 0)
PyErr_Clear();
}
if (curlen < 0)
curlen = 8; /* arbitrary */ curlen = 8; /* arbitrary */
if (curlen > len) }
len = curlen; if (curlen > len)
len = curlen;
} }
/* Get space for the result list. */ /* Get space for the result list. */
...@@ -1968,7 +1964,7 @@ builtin_zip(PyObject *self, PyObject *args) ...@@ -1968,7 +1964,7 @@ builtin_zip(PyObject *self, PyObject *args)
len = -1; /* unknown */ len = -1; /* unknown */
for (i = 0; i < itemsize; ++i) { for (i = 0; i < itemsize; ++i) {
PyObject *item = PyTuple_GET_ITEM(args, i); PyObject *item = PyTuple_GET_ITEM(args, i);
int thislen = PySequence_Length(item); int thislen = PyObject_Size(item);
if (thislen < 0) { if (thislen < 0) {
PyErr_Clear(); PyErr_Clear();
len = -1; len = -1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment