bpo-36292: Mark unreachable code as such in long bitwise ops (GH-12333)

a10d426b · stratakis · Victor Stinner · f7b57df0 · a10d426b
Commit a10d426b authored Mar 18, 2019 by stratakis Committed by Victor Stinner Mar 18, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 4 deletions

Objects/longobject.c Objects/longobject.c +2 -4

No files found.
--- a/Objects/longobject.c
+++ b/Objects/longobject.c
@@ -4637,8 +4637,7 @@ long_bitwise(PyLongObject *a,
        size_z = negb ? size_b : size_a;
        break;
    default:
-        PyErr_BadArgument();
+        Py_UNREACHABLE();
-        return NULL;
    }
    /* We allow an extra digit if z is negative, to make sure that
@@ -4665,8 +4664,7 @@ long_bitwise(PyLongObject *a,
            z->ob_digit[i] = a->ob_digit[i] ^ b->ob_digit[i];
        break;
    default:
-        PyErr_BadArgument();
+        Py_UNREACHABLE();
-        return NULL;
    }
    /* Copy any remaining digits of a, inverting if necessary. */