Fix a possible decref of a borrowed reference in symtable.c. (GH-9786)

fc439d20 · Zackery Spytz · Serhiy Storchaka · 9b8c2e76 · fc439d20
Commit fc439d20 authored Oct 10, 2018 by Zackery Spytz Committed by Serhiy Storchaka Oct 11, 2018
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

Python/symtable.c Python/symtable.c +4 -2

No files found.
--- a/Python/symtable.c
+++ b/Python/symtable.c
@@ -625,8 +625,10 @@ update_symbols(PyObject *symbols, PyObject *scopes,
        return 0;

    itr = PyObject_GetIter(free);
-    if (!itr)
-        goto error;
+    if (itr == NULL) {
+        Py_DECREF(v_free);
+        return 0;
+    }

    while ((name = PyIter_Next(itr))) {
        v = PyDict_GetItem(symbols, name);