From 190313e696239feb6cb8187e1389820817575c4c Mon Sep 17 00:00:00 2001
From: Brad Fitzpatrick <bradfitz@golang.org>
Date: Wed, 24 Jun 2015 12:11:58 +0200
Subject: [PATCH] net/http: document that Hijack's net.Conn might have
left-over timeouts set
Fixes #8296
Change-Id: I71b330a0f961d46ae4ed81d5f3f5ce5bf708a29a
Reviewed-on: https://go-review.googlesource.com/11411
Reviewed-by: Andrew Gerrand <adg@golang.org>
---
src/net/http/server.go | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/net/http/server.go b/src/net/http/server.go
index 008666204d..e17dacc559 100644
--- a/src/net/http/server.go
+++ b/src/net/http/server.go
@@ -97,8 +97,14 @@ type Hijacker interface {
// Hijack lets the caller take over the connection.
// After a call to Hijack(), the HTTP server library
// will not do anything else with the connection.
+ //
// It becomes the caller's responsibility to manage
// and close the connection.
+ //
+ // The returned net.Conn may have read or write deadlines
+ // already set, depending on the configuration of the
+ // Server. It is the caller's responsibility to set
+ // or clear those deadlines as needed.
Hijack() (net.Conn, *bufio.ReadWriter, error)
}
--
2.30.9