• Bill Wendling's avatar
    soc: qcom: smem: use correct format characters · 0ec29ccf
    Bill Wendling authored
    
    
    When compiling with -Wformat, clang emits the following warnings:
    
    drivers/soc/qcom/smem.c:847:41: warning: format specifies type 'unsigned
    short' but the argument has type 'unsigned int' [-Wformat]
                            dev_err(smem->dev, "bad host %hu\n", remote_host);
                                                         ~~~     ^~~~~~~~~~~
                                                         %u
    ./include/linux/dev_printk.h:144:65: note: expanded from macro 'dev_err'
            dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
                                                                   ~~~     ^~~~~~~~~~~
    ./include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap'
                    _p_func(dev, fmt, ##__VA_ARGS__);                       \
                                 ~~~    ^~~~~~~~~~~
    drivers/soc/qcom/smem.c:852:47: warning: format specifies type 'unsigned
    short' but the argument has type 'unsigned int' [-Wformat]
                            dev_err(smem->dev, "duplicate host %hu\n", remote_host);
                                                               ~~~     ^~~~~~~~~~~
                                                               %u
    ./include/linux/dev_printk.h:144:65: note: expanded from macro 'dev_err'
            dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
                                                                   ~~~     ^~~~~~~~~~~
    ./include/linux/dev_printk.h:110:23: note: expanded from macro 'dev_printk_index_wrap'
                    _p_func(dev, fmt, ##__VA_ARGS__);                       \
                                 ~~~    ^~~~~~~~~~~
    
    The types of these arguments are unconditionally defined, so this patch
    updates the format character to the correct one and change type of
    remote_host to "u16" to match with other types.
    Signed-off-by: default avatarBill Wendling <morbo@google.com>
    Tested-by: default avatarJustin Stitt <jstitt007@gmail.com>
    Reviewed-by: default avatarJustin Stitt <jstitt007@gmail.com>
    Link: https://github.com/ClangBuiltLinux/linux/issues/378
    
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    0ec29ccf
smem.c 30.8 KB