• Lukas Wunner's avatar
    usbnet: smsc95xx: Don't reset PHY behind PHY driver's back · 14021da6
    Lukas Wunner authored
    smsc95xx_reset() resets the PHY behind the PHY driver's back, which
    seems like a bad idea generally.  Remove that portion of the function.
    
    We're about to use PHY interrupts instead of polling to detect link
    changes on SMSC LAN95xx chips.  Because smsc95xx_reset() is called from
    usbnet_open(), PHY interrupt settings are lost whenever the net_device
    is brought up.
    
    There are two other callers of smsc95xx_reset(), namely smsc95xx_bind()
    and smsc95xx_reset_resume(), and both may indeed benefit from a PHY
    reset.  However they already perform one through their calls to
    phy_connect_direct() and phy_init_hw().
    
    Tested-by: Oleksij Rempel <o.rempel@pengutronix.de> # LAN9514/9512/9500
    Tested-by: Ferry Toth <fntoth@gmail.com> # LAN9514
    Signed-off-by: default avatarLukas Wunner <lukas@wunner.de>
    Cc: Martyn Welch <martyn.welch@collabora.com>
    Cc: Gabriel Hojda <ghojda@yo2urs.ro>
    Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    14021da6
smsc95xx.c 51.1 KB