• Alexey Kardashevskiy's avatar
    KVM: SEV-ES: explicitly disable debug · 2837dd00
    Alexey Kardashevskiy authored
    SVM/SEV enable debug registers intercepts to skip swapping DRs
    on entering/exiting the guest. When the guest is in control of
    debug registers (vcpu->guest_debug == 0), there is an optimisation to
    reduce the number of context switches: intercepts are cleared and
    the KVM_DEBUGREG_WONT_EXIT flag is set to tell KVM to do swapping
    on guest enter/exit.
    
    The same code also executes for SEV-ES, however it has no effect as
    - it always takes (vcpu->guest_debug == 0) branch;
    - KVM_DEBUGREG_WONT_EXIT is set but DR7 intercept is not cleared;
    - vcpu_enter_guest() writes DRs but VMRUN for SEV-ES swaps them
    with the values from _encrypted_ VMSA.
    
    Be explicit about SEV-ES not supporting debug:
    - return right away from dr_interception() and skip unnecessary processing;
    - return an error right away from the KVM_SEV_LAUNCH_UPDATE_VMSA handler
    if debugging was already enabled.
    KVM_SET_GUEST_DEBUG are failing already after KVM_SEV_LAUNCH_UPDATE_VMSA
    is finished due to vcpu->arch.guest_state_protected set to true.
    
    Add WARN_ON to kvm_x86::sync_dirty_debug_regs() (saves guest DRs on
    guest exit) to signify that SEV-ES won't hit that path.
    Suggested-by: default avatarSean Christopherson <seanjc@google.com>
    Signed-off-by: default avatarAlexey Kardashevskiy <aik@amd.com>
    Link: https://lore.kernel.org/r/20230615063757.3039121-5-aik@amd.comSigned-off-by: default avatarSean Christopherson <seanjc@google.com>
    2837dd00
sev.c 77.1 KB