• Peter Hurley's avatar
    serial: core: Flush ldisc after dropping port mutex in uart_close() · 2e758910
    Peter Hurley authored
    The tty buffers (and any line discipline buffers) must be flushed after
    the UART hardware has shutdown; otherwise, a racing open on the same
    tty may receive data from the previous session, which is a security
    hazard. However, holding the port mutex while flushing the line
    discipline buffers creates a lock inversion if the set_termios()
    handler takes the port mutex (as it does in the followup patch,
    'serial: Fix locking for uart driver set_termios method'.
    
    Flush the ldisc buffers after dropping the port mutex; the tty lock
    is still held which prevents a concurrent open() from advancing while
    flushing. Since no new rx data is possible after uart_shutdown() until
    a new open reinitializes the port, the later flush has no impact on
    what data is being discarded.
    Signed-off-by: default avatarPeter Hurley <peter@hurleysoftware.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    2e758910
serial_core.c 71.2 KB