• Nam Cao's avatar
    fbdev: flush deferred IO before closing · 33cd6ea9
    Nam Cao authored
    When framebuffer gets closed, the queued deferred IO gets cancelled. This
    can cause some last display data to vanish. This is problematic for users
    who send a still image to the framebuffer, then close the file: the image
    may never appear.
    
    To ensure none of display data get lost, flush the queued deferred IO
    first before closing.
    
    Another possible solution is to delete the cancel_delayed_work_sync()
    instead. The difference is that the display may appear some time after
    closing. However, the clearing of page mapping after this needs to be
    removed too, because the page mapping is used by the deferred work. It is
    not completely obvious whether it is okay to not clear the page mapping.
    For a patch intended for stable trees, go with the simple and obvious
    solution.
    
    Fixes: 60b59bea ("fbdev: mm: Deferred IO support")
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarNam Cao <namcao@linutronix.de>
    Reviewed-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
    Signed-off-by: default avatarHelge Deller <deller@gmx.de>
    33cd6ea9
fb_defio.c 8.84 KB