• Mauro Carvalho Chehab's avatar
    media: cx2341x: replace badly designed macros · 3d19cde7
    Mauro Carvalho Chehab authored
    There are some macros at cx2341x_update() with seemed to
    be introduced in order to ensure that lines would be less
    than 80 columns.
    
    Well, the thing is that they make the code harder to be analized,
    not only by humans, but also for static code analyzers:
    
    	drivers/media/common/cx2341x.c:1116 cx2341x_update() error: we previously assumed 'old' could be null (see line 1047)
    
    So, remove the "force" var, and replace the NEQ macro to a
    better designed one that makes clearer about what it is doing.
    
    While here, also remove the "temporal" var, as it is just another
    way of doing the same type of check as the new CMP_FIELD() macro
    already does.
    
    Finally, fix coding style at the block code.
     remove such macros.
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
    3d19cde7
cx2341x.c 56.3 KB