• Yuan Can's avatar
    vhost/vsock: Fix error handling in vhost_vsock_init() · 7a4efe18
    Yuan Can authored
    A problem about modprobe vhost_vsock failed is triggered with the
    following log given:
    
    modprobe: ERROR: could not insert 'vhost_vsock': Device or resource busy
    
    The reason is that vhost_vsock_init() returns misc_register() directly
    without checking its return value, if misc_register() failed, it returns
    without calling vsock_core_unregister() on vhost_transport, resulting the
    vhost_vsock can never be installed later.
    A simple call graph is shown as below:
    
     vhost_vsock_init()
       vsock_core_register() # register vhost_transport
       misc_register()
         device_create_with_groups()
           device_create_groups_vargs()
             dev = kzalloc(...) # OOM happened
       # return without unregister vhost_transport
    
    Fix by calling vsock_core_unregister() when misc_register() returns error.
    
    Fixes: 433fc58e ("VSOCK: Introduce vhost_vsock.ko")
    Signed-off-by: default avatarYuan Can <yuancan@huawei.com>
    Message-Id: <20221108101705.45981-1-yuancan@huawei.com>
    Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    Reviewed-by: default avatarStefano Garzarella <sgarzare@redhat.com>
    Acked-by: default avatarJason Wang <jasowang@redhat.com>
    7a4efe18
vsock.c 24.7 KB