• Matthias Reichl's avatar
    regmap: fix bogus error on regcache_sync success · fea88064
    Matthias Reichl authored
    Since commit 0ec77316 ("regmap: Ensure range selector registers
    are updated after cache sync") opening pcm512x based soundcards fail
    with EINVAL and dmesg shows sync cache and pm_runtime_get errors:
    
    [  228.794676] pcm512x 1-004c: Failed to sync cache: -22
    [  228.794740] pcm512x 1-004c: ASoC: error at snd_soc_pcm_component_pm_runtime_get on pcm512x.1-004c: -22
    
    This is caused by the cache check result leaking out into the
    regcache_sync return value.
    
    Fix this by making the check local-only, as the comment above the
    regcache_read call states a non-zero return value means there's
    nothing to do so the return value should not be altered.
    
    Fixes: 0ec77316 ("regmap: Ensure range selector registers are updated after cache sync")
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarMatthias Reichl <hias@horus.com>
    Link: https://lore.kernel.org/r/20231203222216.96547-1-hias@horus.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    fea88064
regcache.c 18.7 KB