• Jiri Olsa's avatar
    selftests/bpf: Add read_trace_pipe_iter function · 4d4992ff
    Jiri Olsa authored
    We have two printk tests reading trace_pipe in non blocking way,
    with the very same code. Moving that in new read_trace_pipe_iter
    function.
    
    Current read_trace_pipe is used from samples/bpf and needs to
    do blocking read and printf of the trace_pipe data, using new
    read_trace_pipe_iter to implement that.
    
    Both printk tests do early checks for the number of found messages
    and can bail earlier, but I did not find any speed difference w/o
    that condition, so I did not complicate the change more for that.
    
    Some of the samples/bpf programs use read_trace_pipe function,
    so I kept that interface untouched. I did not see any issues with
    affected samples/bpf programs other than there's slight change in
    read_trace_pipe output. The current code uses puts that adds new
    line after the printed string, so we would occasionally see extra
    new line. With this patch we read output per lines, so there's no
    need to use puts and we can use just printf instead without extra
    new line.
    Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
    Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
    Acked-by: default avatarYonghong Song <yonghong.song@linux.dev>
    Link: https://lore.kernel.org/bpf/20240410140952.292261-1-jolsa@kernel.org
    4d4992ff
trace_helpers.c 8.72 KB