• Yury Norov's avatar
    lib/bitmap: drop optimization of bitmap_{from,to}_arr64 · c1d2ba10
    Yury Norov authored
    
    
    bitmap_{from,to}_arr64() optimization is overly optimistic on 32-bit LE
    architectures when it's wired to bitmap_copy_clear_tail().
    
    bitmap_copy_clear_tail() takes care of unused bits in the bitmap up to
    the next word boundary. But on 32-bit machines when copying bits from
    bitmap to array of 64-bit words, it's expected that the unused part of
    a recipient array must be cleared up to 64-bit boundary, so the last 4
    bytes may stay untouched when nbits % 64 <= 32.
    
    While the copying part of the optimization works correct, that clear-tail
    trick makes corresponding tests reasonably fail:
    
    test_bitmap: bitmap_to_arr64(nbits == 1): tail is not safely cleared: 0xa5a5a5a500000001 (must be 0x0000000000000001)
    
    Fix it by removing bitmap_{from,to}_arr64() optimization for 32-bit LE
    arches.
    Reported-by: default avatarGuenter Roeck <linux@roeck-us.net>
    Link: https://lore.kernel.org/lkml/20230225184702.GA3587246@roeck-us.net/
    Fixes: 0a97953f ("lib: add bitmap_{from,to}_arr64")...
    c1d2ba10
bitmap.c 46.3 KB