• Vlastimil Babka's avatar
    mm, slab: unlink slabinfo, sysfs and debugfs immediately · 4ec10268
    Vlastimil Babka authored
    kmem_cache_destroy() includes removing the associated sysfs and debugfs
    directories, and the cache from the list of caches that appears in
    /proc/slabinfo. Currently this might not happen immediately when:
    
    - the cache is SLAB_TYPESAFE_BY_RCU and the cleanup is delayed,
      including the directores removal
    - __kmem_cache_shutdown() fails due to outstanding objects - the
      directories remain indefinitely
    
    When a cache is recreated with the same name, such as due to module
    unload followed by a load, the directories will fail to be recreated for
    the new instance of the cache due to the old directories being present.
    The cache will also appear twice in /proc/slabinfo.
    
    While we want to convert the SLAB_TYPESAFE_BY_RCU cleanup to be
    synchronous again, the second point remains. So let's fix this first and
    have the directories and slabinfo removed immediately in
    kmem_cache_destroy() and regardless of __kmem_cache_shutdown() success.
    
    This should not make debugging harder if __kmem_cache_shutdown() fails,
    because a detailed report of outstanding objects is printed into dmesg
    already due to the failure.
    
    Also simplify kmem_cache_release() sysfs handling by using
    __is_defined(SLAB_SUPPORTS_SYSFS).
    
    Note the resulting code in kmem_cache_destroy() is a bit ugly but will
    be further simplified - this is in order to make small bisectable steps.
    Reviewed-by: default avatarJann Horn <jannh@google.com>
    Signed-off-by: default avatarVlastimil Babka <vbabka@suse.cz>
    4ec10268
slab_common.c 36.1 KB