• Jia-Ju Bai's avatar
    net: wireless: b43legacy: Replace GFP_ATOMIC with GFP_KERNEL in dma_tx_fragment · 6e1d8d14
    Jia-Ju Bai authored
    dma_tx_fragment() is never called in atomic context.
    
    dma_tx_fragment() is only called by b43legacy_dma_tx(), which is
    only called by b43legacy_tx_work().
    b43legacy_tx_work() is only set a parameter of INIT_WORK() in
    b43legacy_wireless_init().
    
    Despite never getting called from atomic context,
    dma_tx_fragment() calls alloc_skb() with GFP_ATOMIC,
    which does not sleep for allocation.
    GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
    which can sleep and improve the possibility of sucessful allocation.
    
    This is found by a static analysis tool named DCNS written by myself.
    And I also manually check it.
    Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
    Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
    6e1d8d14
dma.c 36.6 KB