• Denys Vlasenko's avatar
    x86/asm/entry/32: Remove unnecessary optimization in stub32_clone · 7a5a9824
    Denys Vlasenko authored
    Really swap arguments #4 and #5 in stub32_clone instead of
    "optimizing" it into a move.
    
    Yes, tls_val is currently unused. Yes, on some CPUs XCHG is a
    little bit more expensive than MOV. But a cycle or two on an
    expensive syscall like clone() is way below noise floor, and
    this optimization is simply not worth the obfuscation of logic.
    
    [ There's also ongoing work on the clone() ABI by Josh Triplett
      that will depend on this change later on. ]
    Signed-off-by: default avatarDenys Vlasenko <dvlasenk@redhat.com>
    Cc: Alexei Starovoitov <ast@plumgrid.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Andy Lutomirski <luto@amacapital.net>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Josh Triplett <josh@joshtriplett.org>
    Cc: Kees Cook <keescook@chromium.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Oleg Nesterov <oleg@redhat.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Will Drewry <wad@chromium.org>
    Link: http://lkml.kernel.org/r/1433339930-20880-2-git-send-email-dvlasenk@redhat.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    7a5a9824
ia32entry.S 15.3 KB