• Sergey Shtylyov's avatar
    fbdev: core: cfbcopyarea: fix sloppy typing · 7f33df94
    Sergey Shtylyov authored
    In cfb_copyarea(), the local variable bits_per_line is needlessly typed as
    *unsigned long* -- which is a 32-bit type on the 32-bit arches and a 64-bit
    type on the 64-bit arches; that variable's value is derived from the __u32
    typed fb_fix_screeninfo::line_length field (multiplied by 8u) and a 32-bit
    *unsigned int* type should still be enough to store the # of bits per line.
    
    Found by Linux Verification Center (linuxtesting.org) with the Svace static
    analysis tool.
    Signed-off-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
    Signed-off-by: default avatarHelge Deller <deller@gmx.de>
    7f33df94
cfbcopyarea.c 11.3 KB