• Waiman Long's avatar
    cgroup/cpuset: Optimize cpuset_attach() on v2 · 7fd4da9c
    Waiman Long authored
    
    
    It was found that with the default hierarchy, enabling cpuset in the
    child cgroups can trigger a cpuset_attach() call in each of the child
    cgroups that have tasks with no change in effective cpus and mems. If
    there are many processes in those child cgroups, it will burn quite a
    lot of cpu cycles iterating all the tasks without doing useful work.
    
    Optimizing this case by comparing between the old and new cpusets and
    skip useless update if there is no change in effective cpus and mems.
    Also mems_allowed are less likely to be changed than cpus_allowed. So
    skip changing mm if there is no change in effective_mems and
    CS_MEMORY_MIGRATE is not set.
    
    By inserting some instrumentation code and running a simple command in
    a container 200 times in a cgroup v2 system, it was found that all the
    cpuset_attach() calls are skipped (401 times in total) as there was no
    change in effective cpus and mems.
    Signed-off-by: default avatarWaiman Long <longman@redhat.com>
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    7fd4da9c
cpuset.c 112 KB