• Geert Uytterhoeven's avatar
    spi: Add missing error handling for CS GPIOs · 91b6a564
    Geert Uytterhoeven authored
    [ Upstream commit 1723fdec ]
    
    While devm_gpiod_get_index_optional() returns NULL if the GPIO is not
    present (i.e. -ENOENT), it may still return other error codes, like
    -EPROBE_DEFER.  Currently these are not handled, leading to
    unrecoverable failures later in case of probe deferral:
    
        gpiod_set_consumer_name: invalid GPIO (errorpointer)
        gpiod_direction_output: invalid GPIO (errorpointer)
        gpiod_set_value_cansleep: invalid GPIO (errorpointer)
        gpiod_set_value_cansleep: invalid GPIO (errorpointer)
        gpiod_set_value_cansleep: invalid GPIO (errorpointer)
    
    Detect and propagate errors to fix this.
    
    Fixes: f3186dd8 ("spi: Optionally use GPIO descriptors for CS GPIOs")
    Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
    91b6a564
spi.c 100 KB