• Yafang Shao's avatar
    fs/binfmt_elf: replace open-coded string copy with get_task_comm · 95af469c
    Yafang Shao authored
    It is better to use get_task_comm() instead of the open coded string
    copy as we do in other places.
    
    struct elf_prpsinfo is used to dump the task information in userspace
    coredump or kernel vmcore.  Below is the verification of vmcore,
    
      crash> ps
         PID    PPID  CPU       TASK        ST  %MEM     VSZ    RSS  COMM
            0      0   0  ffffffff9d21a940  RU   0.0       0      0  [swapper/0]
      >     0      0   1  ffffa09e40f85e80  RU   0.0       0      0  [swapper/1]
      >     0      0   2  ffffa09e40f81f80  RU   0.0       0      0  [swapper/2]
      >     0      0   3  ffffa09e40f83f00  RU   0.0       0      0  [swapper/3]
      >     0      0   4  ffffa09e40f80000  RU   0.0       0      0  [swapper/4]
      >     0      0   5  ffffa09e40f89f80  RU   0.0       0      0  [swapper/5]
            0      0   6  ffffa09e40f8bf00  RU   0.0       0      0  [swapper/6]
      >     0      0   7  ffffa09e40f88000  RU   0.0       0      0  [swapper/7]
      >     0      0   8  ffffa09e40f8de80  RU   0.0       0      0  [swapper/8]
      >     0      0   9  ffffa09e40f95e80  RU   0.0       0      0  [swapper/9]
      >     0      0  10  ffffa09e40f91f80  RU   0.0       0      0  [swapper/10]
      >     0      0  11  ffffa09e40f93f00  RU   0.0       0      0  [swapper/11]
      >     0      0  12  ffffa09e40f90000  RU   0.0       0      0  [swapper/12]
      >     0      0  13  ffffa09e40f9bf00  RU   0.0       0      0  [swapper/13]
      >     0      0  14  ffffa09e40f98000  RU   0.0       0      0  [swapper/14]
      >     0      0  15  ffffa09e40f9de80  RU   0.0       0      0  [swapper/15]
    
    It works well as expected.
    
    Some comments are added to explain why we use the hard-coded 16.
    
    Link: https://lkml.kernel.org/r/20211120112738.45980-5-laoar.shao@gmail.comSuggested-by: default avatarKees Cook <keescook@chromium.org>
    Signed-off-by: default avatarYafang Shao <laoar.shao@gmail.com>
    Reviewed-by: default avatarDavid Hildenbrand <david@redhat.com>
    Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
    Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
    Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>
    Cc: Michal Miroslaw <mirq-linux@rere.qmqm.pl>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Cc: Matthew Wilcox <willy@infradead.org>
    Cc: David Hildenbrand <david@redhat.com>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Cc: Kees Cook <keescook@chromium.org>
    Cc: Petr Mladek <pmladek@suse.com>
    Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>
    Cc: Andrii Nakryiko <andrii@kernel.org>
    Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    95af469c
binfmt_elf.c 60.8 KB