• Nathan Lynch's avatar
    powerpc/pseries: block untrusted device tree changes when locked down · 99df7a28
    Nathan Lynch authored
    The /proc/powerpc/ofdt interface allows the root user to freely alter
    the in-kernel device tree, enabling arbitrary physical address writes
    via drivers that could bind to malicious device nodes, thus making it
    possible to disable lockdown.
    
    Historically this interface has been used on the pseries platform to
    facilitate the runtime addition and removal of processor, memory, and
    device resources (aka Dynamic Logical Partitioning or DLPAR). Years
    ago, the processor and memory use cases were migrated to designs that
    happen to be lockdown-friendly: device tree updates are communicated
    directly to the kernel from firmware without passing through untrusted
    user space. I/O device DLPAR via the "drmgr" command in powerpc-utils
    remains the sole legitimate user of /proc/powerpc/ofdt, but it is
    already broken in lockdown since it uses /dev/mem to allocate argument
    buffers for the rtas syscall. So only illegitimate uses of the
    interface should see a behavior change when running on a locked down
    kernel.
    Signed-off-by: default avatarNathan Lynch <nathanl@linux.ibm.com>
    Acked-by: Paul Moore <paul@paul-moore.com> (LSM)
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    Link: https://lore.kernel.org/r/20220926131643.146502-2-nathanl@linux.ibm.com
    99df7a28
security.c 66.6 KB