• Eric Sandeen's avatar
    xfs: revert "xfs: actually bump warning counts when we send warnings" · bc37e4fb
    Eric Sandeen authored
    This reverts commit 4b8628d5.
    
    XFS quota has had the concept of a "quota warning limit" since
    the earliest Irix implementation, but a mechanism for incrementing
    the warning counter was never implemented, as documented in the
    xfs_quota(8) man page. We do know from the historical archive that
    it was never incremented at runtime during quota reservation
    operations.
    
    With this commit, the warning counter quickly increments for every
    allocation attempt after the user has crossed a quote soft
    limit threshold, and this in turn transitions the user to hard
    quota failures, rendering soft quota thresholds and timers useless.
    This was reported as a regression by users.
    
    Because the intended behavior of this warning counter has never been
    understood or documented, and the result of this change is a regression
    in soft quota functionality, revert this commit to make soft quota
    limits and timers operable again.
    
    Fixes: 4b8628d5 ("xfs: actually bump warning counts when we send warnings)
    Signed-off-by: default avatarEric Sandeen <sandeen@redhat.com>
    Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
    Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
    Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
    bc37e4fb
xfs_trans_dquot.c 20.4 KB