• Ian Abbott's avatar
    spi: spidev: fix possible arithmetic overflow for multi-transfer message · a53a7ec9
    Ian Abbott authored
    commit f20fbaad upstream.
    
    `spidev_message()` sums the lengths of the individual SPI transfers to
    determine the overall SPI message length.  It restricts the total
    length, returning an error if too long, but it does not check for
    arithmetic overflow.  For example, if the SPI message consisted of two
    transfers and the first has a length of 10 and the second has a length
    of (__u32)(-1), the total length would be seen as 9, even though the
    second transfer is actually very long.  If the second transfer specifies
    a null `rx_buf` and a non-null `tx_buf`, the `copy_from_user()` could
    overrun the spidev's pre-allocated tx buffer before it reaches an
    invalid user memory address.  Fix it by checking that neither the total
    nor the individual transfer lengths exceed the maximum allowed value.
    
    Thanks to Dan Carpenter for reporting the potential integer overflow.
    Signed-off-by: default avatarIan Abbott <abbotti@mev.co.uk>
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    [ luis: backported to 3.16: used backport provided by Ian ]
    Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
    a53a7ec9
spidev.c 18 KB