• Like Xu's avatar
    perf config: Refine error message to eliminate confusion · a827c007
    Like Xu authored
    If there is no configuration file at first, the user can write any pair
    of "key.subkey=value" to the newly created configuration file, while
    value validation against a valid configurable key is *deferred* until
    the next execution or the implied execution of "perf config ... ".
    
    For example:
    
      $ rm ~/.perfconfig
      $ perf config call-graph.dump-size=65529
      $ cat ~/.perfconfig
      # this file is auto-generated.
      [call-graph]
     	dump-size = 65529
      $ perf config call-graph.dump-size=2048
      callchain: Incorrect stack dump size (max 65528): 65529
      Error: wrong config key-value pair call-graph.dump-size=65529
    
    The user might expect that the second value 2048 is valid and can be
    updated to the configuration file, but the error message is very
    confusing because the first value 65529 is not reported as an error
    during the last configuration.
    
    It is recommended not to change the current behavior of delayed
    validation (as more effort is needed), but to refine the original error
    message to *clearly indicate* that the cause of the error is the
    configuration file.
    Signed-off-by: default avatarLike Xu <likexu@tencent.com>
    Acked-by: default avatarIan Rogers <irogers@google.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lore.kernel.org/lkml/20210924115817.58689-1-likexu@tencent.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    a827c007
config.c 18.2 KB