• Amir Goldstein's avatar
    ovl: use ovl_inode_lock in ovl_llseek() · b1f9d385
    Amir Goldstein authored
    In ovl_llseek() we use the overlay inode rwsem to protect against
    concurrent modifications to real file f_pos, because we copy the overlay
    file f_pos to/from the real file f_pos.
    
    This caused a lockdep warning of locking order violation when the
    ovl_llseek() operation was called on a lower nested overlay layer while the
    upper layer fs sb_writers is held (with patch improving copy-up efficiency
    for big sparse file).
    
    Use the internal ovl_inode_lock() instead of the overlay inode rwsem in
    those cases. It is meant to be used for protecting against concurrent
    changes to overlay inode internal state changes.
    
    The locking order rules are documented to explain this case.
    Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
    Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
    b1f9d385
file.c 13.8 KB