• Tejun Heo's avatar
    kernfs: use dumber locking for kernfs_find_and_get_node_by_ino() · b680b081
    Tejun Heo authored
    kernfs_find_and_get_node_by_ino() uses RCU protection.  It's currently
    a bit buggy because it can look up a node which hasn't been activated
    yet and thus may end up exposing a node that the kernfs user is still
    prepping.
    
    While it can be fixed by pushing it further in the current direction,
    it's already complicated and isn't clear whether the complexity is
    justified.  The main use of kernfs_find_and_get_node_by_ino() is for
    exportfs operations.  They aren't super hot and all the follow-up
    operations (e.g. mapping to path) use normal locking anyway.
    
    Let's switch to a dumber locking scheme and protect the lookup with
    kernfs_idr_lock.
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    b680b081
mount.c 9.19 KB