• Dave Jones's avatar
    ext4: fix memory leak in xattr · 6e4ea8e3
    Dave Jones authored
    If we take the 2nd retry path in ext4_expand_extra_isize_ea, we
    potentionally return from the function without having freed these
    allocations.  If we don't do the return, we over-write the previous
    allocation pointers, so we leak either way.
    
    Spotted with Coverity.
    
    [ Fixed by tytso to set is and bs to NULL after freeing these
      pointers, in case in the retry loop we later end up triggering an
      error causing a jump to cleanup, at which point we could have a double
      free bug. -- Ted ]
    Signed-off-by: default avatarDave Jones <davej@fedoraproject.org>
    Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
    Reviewed-by: default avatarEric Sandeen <sandeen@redhat.com>
    Cc: stable@vger.kernel.org
    6e4ea8e3
xattr.c 44.5 KB