• Hui Peng's avatar
    ath10k: Fix a NULL-ptr-deref bug in ath10k_usb_alloc_urb_from_pipe · bfd6e6e6
    Hui Peng authored
    The `ar_usb` field of `ath10k_usb_pipe_usb_pipe` objects
    are initialized to point to the containing `ath10k_usb` object
    according to endpoint descriptors read from the device side, as shown
    below in `ath10k_usb_setup_pipe_resources`:
    
    for (i = 0; i < iface_desc->desc.bNumEndpoints; ++i) {
            endpoint = &iface_desc->endpoint[i].desc;
    
            // get the address from endpoint descriptor
            pipe_num = ath10k_usb_get_logical_pipe_num(ar_usb,
                                                    endpoint->bEndpointAddress,
                                                    &urbcount);
            ......
            // select the pipe object
            pipe = &ar_usb->pipes[pipe_num];
    
            // initialize the ar_usb field
            pipe->ar_usb = ar_usb;
    }
    
    The driver assumes that the addresses reported in endpoint
    descriptors from device side  to be complete. If a device is
    malicious and does not report complete addresses, it may trigger
    NULL-ptr-deref `ath10k_usb_alloc_urb_from_pipe` and
    `ath10k_usb_free_urb_to_pipe`.
    
    This patch fixes the bug by preventing potential NULL-ptr-deref.
    Signed-off-by: default avatarHui Peng <benquike@gmail.com>
    Reported-by: default avatarHui Peng <benquike@gmail.com>
    Reported-by: default avatarMathias Payer <mathias.payer@nebelwelt.net>
    Reviewed-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    [groeck: Add driver tag to subject, fix build warning]
    Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
    Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
    bfd6e6e6
usb.c 27 KB