• Cupertino Miranda's avatar
    bpf/verifier: replace calls to mark_reg_unknown. · d786957e
    Cupertino Miranda authored
    In order to further simplify the code in adjust_scalar_min_max_vals all
    the calls to mark_reg_unknown are replaced by __mark_reg_unknown.
    
    static void mark_reg_unknown(struct bpf_verifier_env *env,
      			     struct bpf_reg_state *regs, u32 regno)
    {
    	if (WARN_ON(regno >= MAX_BPF_REG)) {
    		... mark all regs not init ...
    		return;
        }
    	__mark_reg_unknown(env, regs + regno);
    }
    
    The 'regno >= MAX_BPF_REG' does not apply to
    adjust_scalar_min_max_vals(), because it is only called from the
    following stack:
      - check_alu_op
        - adjust_reg_min_max_vals
          - adjust_scalar_min_max_vals
    
    The check_alu_op() does check_reg_arg() which verifies that both src and
    dst register numbers are within bounds.
    Signed-off-by: default avatarCupertino Miranda <cupertino.miranda@oracle.com>
    Acked-by: default avatarEduard Zingerman <eddyz87@gmail.com>
    Cc: Yonghong Song <yonghong.song@linux.dev>
    Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>
    Cc: David Faust <david.faust@oracle.com>
    Cc: Jose Marchesi <jose.marchesi@oracle.com>
    Cc: Elena Zannoni <elena.zannoni@oracle.com>
    Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>
    Link: https://lore.kernel.org/r/20240506141849.185293-2-cupertino.miranda@oracle.comSigned-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
    d786957e
verifier.c 648 KB