• Ayush Sawal's avatar
    xfrm: Fix xfrm offload fallback fail case · dd72fadf
    Ayush Sawal authored
    In case of xfrm offload, if xdo_dev_state_add() of driver returns
    -EOPNOTSUPP, xfrm offload fallback is failed.
    In xfrm state_add() both xso->dev and xso->real_dev are initialized to
    dev and when err(-EOPNOTSUPP) is returned only xso->dev is set to null.
    
    So in this scenario the condition in func validate_xmit_xfrm(),
    if ((x->xso.dev != dev) && (x->xso.real_dev == dev))
                    return skb;
    returns true, due to which skb is returned without calling esp_xmit()
    below which has fallback code. Hence the CRYPTO_FALLBACK is failing.
    
    So fixing this with by keeping x->xso.real_dev as NULL when err is
    returned in func xfrm_dev_state_add().
    
    Fixes: bdfd2d1f ("bonding/xfrm: use real_dev instead of slave_dev")
    Signed-off-by: default avatarAyush Sawal <ayush.sawal@chelsio.com>
    Signed-off-by: default avatarSteffen Klassert <steffen.klassert@secunet.com>
    dd72fadf
xfrm_device.c 9.65 KB