• Dominique Martinet's avatar
    9p: Fix DIO read through netfs · e3786b29
    Dominique Martinet authored
    If a program is watching a file on a 9p mount, it won't see any change in
    size if the file being exported by the server is changed directly in the
    source filesystem, presumably because 9p doesn't have change notifications,
    and because netfs skips the reads if the file is empty.
    
    Fix this by attempting to read the full size specified when a DIO read is
    requested (such as when 9p is operating in unbuffered mode) and dealing
    with a short read if the EOF was less than the expected read.
    
    To make this work, filesystems using netfslib must not set
    NETFS_SREQ_CLEAR_TAIL if performing a DIO read where that read hit the EOF.
    I don't want to mandatorily clear this flag in netfslib for DIO because,
    say, ceph might make a read from an object that is not completely filled,
    but does not reside at the end of file - and so we need to clear the
    excess.
    
    This can be tested by watching an empty file over 9p within a VM (such as
    in the ktest framework):
    
            while true; do read content; if [ -n "$content" ]; then echo $content; break; fi; done < /host/tmp/foo
    
    then writing something into the empty file.  The watcher should immediately
    display the file content and break out of the loop.  Without this fix, it
    remains in the loop indefinitely.
    
    Fixes: 80105ed2 ("9p: Use netfslib read/write_iter")
    Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218916Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
    Link: https://lore.kernel.org/r/1229195.1723211769@warthog.procyon.org.uk
    cc: Eric Van Hensbergen <ericvh@kernel.org>
    cc: Latchesar Ionkov <lucho@ionkov.net>
    cc: Christian Schoenebeck <linux_oss@crudebyte.com>
    cc: Marc Dionne <marc.dionne@auristor.com>
    cc: Ilya Dryomov <idryomov@gmail.com>
    cc: Steve French <sfrench@samba.org>
    cc: Paulo Alcantara <pc@manguebit.com>
    cc: Trond Myklebust <trond.myklebust@hammerspace.com>
    cc: v9fs@lists.linux.dev
    cc: linux-afs@lists.infradead.org
    cc: ceph-devel@vger.kernel.org
    cc: linux-cifs@vger.kernel.org
    cc: linux-nfs@vger.kernel.org
    cc: netfs@lists.linux.dev
    cc: linux-fsdevel@vger.kernel.org
    Signed-off-by: default avatarDominique Martinet <asmadeus@codewreck.org>
    Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
    e3786b29
file.c 88 KB