• Tejun Heo's avatar
    workqueue: improve destroy_workqueue() debuggability · e41e704b
    Tejun Heo authored
    Now that the worklist is global, having works pending after wq
    destruction can easily lead to oops and destroy_workqueue() have
    several BUG_ON()s to catch these cases.  Unfortunately, BUG_ON()
    doesn't tell much about how the work became pending after the final
    flush_workqueue().
    
    This patch adds WQ_DYING which is set before the final flush begins.
    If a work is requested to be queued on a dying workqueue,
    WARN_ON_ONCE() is triggered and the request is ignored.  This clearly
    indicates which caller is trying to queue a work on a dying workqueue
    and keeps the system working in most cases.
    
    Locking rule comment is updated such that the 'I' rule includes
    modifying the field from destruction path.
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    e41e704b
workqueue.h 12 KB