• Peter Xu's avatar
    mm: check against orig_pte for finish_fault() · f46f2ade
    Peter Xu authored
    This patch allows do_fault() to trigger on !pte_none() cases too.  This
    prepares for the pte markers to be handled by do_fault() just like none
    pte.
    
    To achieve this, instead of unconditionally check against pte_none() in
    finish_fault(), we may hit the case that the orig_pte was some pte marker
    so what we want to do is to replace the pte marker with some valid pte
    entry.  Then if orig_pte was set we'd want to check the current *pte
    (under pgtable lock) against orig_pte rather than none pte.
    
    Right now there's no solid way to safely reference orig_pte because when
    pmd is not allocated handle_pte_fault() will not initialize orig_pte, so
    it's not safe to reference it.
    
    There's another solution proposed before this patch to do pte_clear() for
    vmf->orig_pte for pmd==NULL case, however it turns out it'll break arm32
    because arm32 could have assumption that pte_t* pointer will always reside
    on a real ram32 pgtable, not any kernel stack variable.
    
    To solve this, we add a new flag FAULT_FLAG_ORIG_PTE_VALID, and it'll be
    set along with orig_pte when there is valid orig_pte, or it'll be cleared
    when orig_pte was not initialized.
    
    It'll be updated every time we call handle_pte_fault(), so e.g.  if a page
    fault retry happened it'll be properly updated along with orig_pte.
    
    [1] https://lore.kernel.org/lkml/710c48c9-406d-e4c5-a394-10501b951316@samsung.com/
    
    [akpm@linux-foundation.org: coding-style cleanups]
    [peterx@redhat.com: fix crash reported by Marek]
      Link: https://lkml.kernel.org/r/Ylb9rXJyPm8/ao8f@xz-m1.local
    Link: https://lkml.kernel.org/r/20220405014836.14077-1-peterx@redhat.comSigned-off-by: default avatarPeter Xu <peterx@redhat.com>
    Reviewed-by: default avatarAlistair Popple <apopple@nvidia.com>
    Tested-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
    Cc: Andrea Arcangeli <aarcange@redhat.com>
    Cc: Axel Rasmussen <axelrasmussen@google.com>
    Cc: David Hildenbrand <david@redhat.com>
    Cc: Hugh Dickins <hughd@google.com>
    Cc: Jerome Glisse <jglisse@redhat.com>
    Cc: "Kirill A . Shutemov" <kirill@shutemov.name>
    Cc: Matthew Wilcox <willy@infradead.org>
    Cc: Mike Kravetz <mike.kravetz@oracle.com>
    Cc: Mike Rapoport <rppt@linux.vnet.ibm.com>
    Cc: Nadav Amit <nadav.amit@gmail.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    f46f2ade
memory.c 154 KB