Commit 00b8c95b authored by Chengyu Song's avatar Chengyu Song Committed by Steve French

cifs: potential missing check for posix_lock_file_wait

posix_lock_file_wait may fail under certain circumstances, and its result is
usually checked/returned. But given the complexity of cifs, I'm not sure if
the result is intentially left unchecked and always expected to succeed.
Signed-off-by: default avatarChengyu Song <csong84@gatech.edu>
Acked-by: default avatarJeff Layton <jeff.layton@primarydata.com>
Signed-off-by: default avatarSteve French <smfrench@gmail.com>
parent 7196ac11
...@@ -1552,8 +1552,8 @@ cifs_setlk(struct file *file, struct file_lock *flock, __u32 type, ...@@ -1552,8 +1552,8 @@ cifs_setlk(struct file *file, struct file_lock *flock, __u32 type,
rc = server->ops->mand_unlock_range(cfile, flock, xid); rc = server->ops->mand_unlock_range(cfile, flock, xid);
out: out:
if (flock->fl_flags & FL_POSIX) if (flock->fl_flags & FL_POSIX && !rc)
posix_lock_file_wait(file, flock); rc = posix_lock_file_wait(file, flock);
return rc; return rc;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment