Commit 04bdbdf9 authored by Viresh Kumar's avatar Viresh Kumar Committed by Eduardo Valentin

thermal: cpu_cooling: replace cool_dev with cdev

Objects of "struct thermal_cooling_device" are named a bit
inconsistently. Lets use cdev everywhere.
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: default avatarLukasz Luba <lukasz.luba@arm.com>
Tested-by: default avatarLukasz Luba <lukasz.luba@arm.com>
Signed-off-by: default avatarEduardo Valentin <edubezval@gmail.com>
parent 1dea432a
...@@ -65,7 +65,7 @@ struct power_table { ...@@ -65,7 +65,7 @@ struct power_table {
* struct cpufreq_cooling_device - data for cooling device with cpufreq * struct cpufreq_cooling_device - data for cooling device with cpufreq
* @id: unique integer value corresponding to each cpufreq_cooling_device * @id: unique integer value corresponding to each cpufreq_cooling_device
* registered. * registered.
* @cool_dev: thermal_cooling_device pointer to keep track of the * @cdev: thermal_cooling_device pointer to keep track of the
* registered cooling device. * registered cooling device.
* @cpufreq_state: integer value representing the current state of cpufreq * @cpufreq_state: integer value representing the current state of cpufreq
* cooling devices. * cooling devices.
...@@ -90,7 +90,7 @@ struct power_table { ...@@ -90,7 +90,7 @@ struct power_table {
*/ */
struct cpufreq_cooling_device { struct cpufreq_cooling_device {
int id; int id;
struct thermal_cooling_device *cool_dev; struct thermal_cooling_device *cdev;
unsigned int cpufreq_state; unsigned int cpufreq_state;
unsigned int clipped_freq; unsigned int clipped_freq;
unsigned int max_level; unsigned int max_level;
...@@ -242,7 +242,7 @@ static int build_dyn_power_table(struct cpufreq_cooling_device *cpufreq_cdev, ...@@ -242,7 +242,7 @@ static int build_dyn_power_table(struct cpufreq_cooling_device *cpufreq_cdev,
for_each_cpu(cpu, &cpufreq_cdev->allowed_cpus) { for_each_cpu(cpu, &cpufreq_cdev->allowed_cpus) {
dev = get_cpu_device(cpu); dev = get_cpu_device(cpu);
if (!dev) { if (!dev) {
dev_warn(&cpufreq_cdev->cool_dev->device, dev_warn(&cpufreq_cdev->cdev->device,
"No cpu device for cpu %d\n", cpu); "No cpu device for cpu %d\n", cpu);
continue; continue;
} }
...@@ -769,7 +769,7 @@ __cpufreq_cooling_register(struct device_node *np, ...@@ -769,7 +769,7 @@ __cpufreq_cooling_register(struct device_node *np,
get_static_t plat_static_func) get_static_t plat_static_func)
{ {
struct cpufreq_policy *policy; struct cpufreq_policy *policy;
struct thermal_cooling_device *cool_dev; struct thermal_cooling_device *cdev;
struct cpufreq_cooling_device *cpufreq_cdev; struct cpufreq_cooling_device *cpufreq_cdev;
char dev_name[THERMAL_NAME_LENGTH]; char dev_name[THERMAL_NAME_LENGTH];
struct cpufreq_frequency_table *pos, *table; struct cpufreq_frequency_table *pos, *table;
...@@ -786,20 +786,20 @@ __cpufreq_cooling_register(struct device_node *np, ...@@ -786,20 +786,20 @@ __cpufreq_cooling_register(struct device_node *np,
policy = cpufreq_cpu_get(cpumask_first(temp_mask)); policy = cpufreq_cpu_get(cpumask_first(temp_mask));
if (!policy) { if (!policy) {
pr_debug("%s: CPUFreq policy not found\n", __func__); pr_debug("%s: CPUFreq policy not found\n", __func__);
cool_dev = ERR_PTR(-EPROBE_DEFER); cdev = ERR_PTR(-EPROBE_DEFER);
goto free_cpumask; goto free_cpumask;
} }
table = policy->freq_table; table = policy->freq_table;
if (!table) { if (!table) {
pr_debug("%s: CPUFreq table not found\n", __func__); pr_debug("%s: CPUFreq table not found\n", __func__);
cool_dev = ERR_PTR(-ENODEV); cdev = ERR_PTR(-ENODEV);
goto put_policy; goto put_policy;
} }
cpufreq_cdev = kzalloc(sizeof(*cpufreq_cdev), GFP_KERNEL); cpufreq_cdev = kzalloc(sizeof(*cpufreq_cdev), GFP_KERNEL);
if (!cpufreq_cdev) { if (!cpufreq_cdev) {
cool_dev = ERR_PTR(-ENOMEM); cdev = ERR_PTR(-ENOMEM);
goto put_policy; goto put_policy;
} }
...@@ -808,7 +808,7 @@ __cpufreq_cooling_register(struct device_node *np, ...@@ -808,7 +808,7 @@ __cpufreq_cooling_register(struct device_node *np,
sizeof(*cpufreq_cdev->time_in_idle), sizeof(*cpufreq_cdev->time_in_idle),
GFP_KERNEL); GFP_KERNEL);
if (!cpufreq_cdev->time_in_idle) { if (!cpufreq_cdev->time_in_idle) {
cool_dev = ERR_PTR(-ENOMEM); cdev = ERR_PTR(-ENOMEM);
goto free_cdev; goto free_cdev;
} }
...@@ -816,7 +816,7 @@ __cpufreq_cooling_register(struct device_node *np, ...@@ -816,7 +816,7 @@ __cpufreq_cooling_register(struct device_node *np,
kcalloc(num_cpus, sizeof(*cpufreq_cdev->time_in_idle_timestamp), kcalloc(num_cpus, sizeof(*cpufreq_cdev->time_in_idle_timestamp),
GFP_KERNEL); GFP_KERNEL);
if (!cpufreq_cdev->time_in_idle_timestamp) { if (!cpufreq_cdev->time_in_idle_timestamp) {
cool_dev = ERR_PTR(-ENOMEM); cdev = ERR_PTR(-ENOMEM);
goto free_time_in_idle; goto free_time_in_idle;
} }
...@@ -827,7 +827,7 @@ __cpufreq_cooling_register(struct device_node *np, ...@@ -827,7 +827,7 @@ __cpufreq_cooling_register(struct device_node *np,
cpufreq_cdev->freq_table = kmalloc(sizeof(*cpufreq_cdev->freq_table) * cpufreq_cdev->freq_table = kmalloc(sizeof(*cpufreq_cdev->freq_table) *
cpufreq_cdev->max_level, GFP_KERNEL); cpufreq_cdev->max_level, GFP_KERNEL);
if (!cpufreq_cdev->freq_table) { if (!cpufreq_cdev->freq_table) {
cool_dev = ERR_PTR(-ENOMEM); cdev = ERR_PTR(-ENOMEM);
goto free_time_in_idle_timestamp; goto free_time_in_idle_timestamp;
} }
...@@ -841,7 +841,7 @@ __cpufreq_cooling_register(struct device_node *np, ...@@ -841,7 +841,7 @@ __cpufreq_cooling_register(struct device_node *np,
ret = build_dyn_power_table(cpufreq_cdev, capacitance); ret = build_dyn_power_table(cpufreq_cdev, capacitance);
if (ret) { if (ret) {
cool_dev = ERR_PTR(ret); cdev = ERR_PTR(ret);
goto free_table; goto free_table;
} }
...@@ -852,7 +852,7 @@ __cpufreq_cooling_register(struct device_node *np, ...@@ -852,7 +852,7 @@ __cpufreq_cooling_register(struct device_node *np,
ret = ida_simple_get(&cpufreq_ida, 0, 0, GFP_KERNEL); ret = ida_simple_get(&cpufreq_ida, 0, 0, GFP_KERNEL);
if (ret < 0) { if (ret < 0) {
cool_dev = ERR_PTR(ret); cdev = ERR_PTR(ret);
goto free_power_table; goto free_power_table;
} }
cpufreq_cdev->id = ret; cpufreq_cdev->id = ret;
...@@ -872,14 +872,13 @@ __cpufreq_cooling_register(struct device_node *np, ...@@ -872,14 +872,13 @@ __cpufreq_cooling_register(struct device_node *np,
snprintf(dev_name, sizeof(dev_name), "thermal-cpufreq-%d", snprintf(dev_name, sizeof(dev_name), "thermal-cpufreq-%d",
cpufreq_cdev->id); cpufreq_cdev->id);
cool_dev = thermal_of_cooling_device_register(np, dev_name, cdev = thermal_of_cooling_device_register(np, dev_name, cpufreq_cdev,
cpufreq_cdev, cooling_ops);
cooling_ops); if (IS_ERR(cdev))
if (IS_ERR(cool_dev))
goto remove_ida; goto remove_ida;
cpufreq_cdev->clipped_freq = cpufreq_cdev->freq_table[0]; cpufreq_cdev->clipped_freq = cpufreq_cdev->freq_table[0];
cpufreq_cdev->cool_dev = cool_dev; cpufreq_cdev->cdev = cdev;
mutex_lock(&cooling_list_lock); mutex_lock(&cooling_list_lock);
/* Register the notifier for first cpufreq cooling device */ /* Register the notifier for first cpufreq cooling device */
...@@ -909,7 +908,7 @@ __cpufreq_cooling_register(struct device_node *np, ...@@ -909,7 +908,7 @@ __cpufreq_cooling_register(struct device_node *np,
cpufreq_cpu_put(policy); cpufreq_cpu_put(policy);
free_cpumask: free_cpumask:
free_cpumask_var(temp_mask); free_cpumask_var(temp_mask);
return cool_dev; return cdev;
} }
/** /**
...@@ -1047,7 +1046,7 @@ void cpufreq_cooling_unregister(struct thermal_cooling_device *cdev) ...@@ -1047,7 +1046,7 @@ void cpufreq_cooling_unregister(struct thermal_cooling_device *cdev)
cpufreq_unregister_notifier(&thermal_cpufreq_notifier_block, cpufreq_unregister_notifier(&thermal_cpufreq_notifier_block,
CPUFREQ_POLICY_NOTIFIER); CPUFREQ_POLICY_NOTIFIER);
thermal_cooling_device_unregister(cpufreq_cdev->cool_dev); thermal_cooling_device_unregister(cpufreq_cdev->cdev);
ida_simple_remove(&cpufreq_ida, cpufreq_cdev->id); ida_simple_remove(&cpufreq_ida, cpufreq_cdev->id);
kfree(cpufreq_cdev->dyn_power_table); kfree(cpufreq_cdev->dyn_power_table);
kfree(cpufreq_cdev->time_in_idle_timestamp); kfree(cpufreq_cdev->time_in_idle_timestamp);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment