Commit 05cef2c4 authored by Miguel Ojeda's avatar Miguel Ojeda

rust: kunit: use C-string literals to clean warning

Starting with upstream Rust commit a5e3a3f9b6bd ("move
`manual_c_str_literals` to complexity"), to be released in Rust 1.83.0
[1], Clippy now warns on `manual_c_str_literals` by default, e.g.:

    error: manually constructing a nul-terminated string
      --> rust/kernel/kunit.rs:21:13
       |
    21 |             b"\x013%pA\0".as_ptr() as _,
       |             ^^^^^^^^^^^^^ help: use a `c""` literal: `c"\x013%pA"`
       |
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_c_str_literals
       = note: `-D clippy::manual-c-str-literals` implied by `-D warnings`
       = help: to override `-D warnings` add `#[allow(clippy::manual_c_str_literals)]`

Apply the suggestion to clean up the warnings.

Link: https://github.com/rust-lang/rust-clippy/pull/13263 [1]
Reviewed-by: default avatarTrevor Gross <tmgross@umich.edu>
Reviewed-by: default avatarBenno Lossin <benno.lossin@proton.me>
Link: https://lore.kernel.org/r/20240927164414.560906-1-ojeda@kernel.orgSigned-off-by: default avatarMiguel Ojeda <ojeda@kernel.org>
parent 4c66f830
...@@ -18,7 +18,7 @@ pub fn err(args: fmt::Arguments<'_>) { ...@@ -18,7 +18,7 @@ pub fn err(args: fmt::Arguments<'_>) {
#[cfg(CONFIG_PRINTK)] #[cfg(CONFIG_PRINTK)]
unsafe { unsafe {
bindings::_printk( bindings::_printk(
b"\x013%pA\0".as_ptr() as _, c"\x013%pA".as_ptr() as _,
&args as *const _ as *const c_void, &args as *const _ as *const c_void,
); );
} }
...@@ -34,7 +34,7 @@ pub fn info(args: fmt::Arguments<'_>) { ...@@ -34,7 +34,7 @@ pub fn info(args: fmt::Arguments<'_>) {
#[cfg(CONFIG_PRINTK)] #[cfg(CONFIG_PRINTK)]
unsafe { unsafe {
bindings::_printk( bindings::_printk(
b"\x016%pA\0".as_ptr() as _, c"\x016%pA".as_ptr() as _,
&args as *const _ as *const c_void, &args as *const _ as *const c_void,
); );
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment