Commit 07409cf7 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Jakub Kicinski

net: wan: fsl_qmc_hdlc: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarHerve Codina <herve.codina@bootlin.com>
Link: https://lore.kernel.org/r/20240409091203.39062-2-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 4ede4575
...@@ -765,15 +765,13 @@ static int qmc_hdlc_probe(struct platform_device *pdev) ...@@ -765,15 +765,13 @@ static int qmc_hdlc_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int qmc_hdlc_remove(struct platform_device *pdev) static void qmc_hdlc_remove(struct platform_device *pdev)
{ {
struct qmc_hdlc *qmc_hdlc = platform_get_drvdata(pdev); struct qmc_hdlc *qmc_hdlc = platform_get_drvdata(pdev);
unregister_hdlc_device(qmc_hdlc->netdev); unregister_hdlc_device(qmc_hdlc->netdev);
free_netdev(qmc_hdlc->netdev); free_netdev(qmc_hdlc->netdev);
qmc_hdlc_framer_exit(qmc_hdlc); qmc_hdlc_framer_exit(qmc_hdlc);
return 0;
} }
static const struct of_device_id qmc_hdlc_id_table[] = { static const struct of_device_id qmc_hdlc_id_table[] = {
...@@ -788,7 +786,7 @@ static struct platform_driver qmc_hdlc_driver = { ...@@ -788,7 +786,7 @@ static struct platform_driver qmc_hdlc_driver = {
.of_match_table = qmc_hdlc_id_table, .of_match_table = qmc_hdlc_id_table,
}, },
.probe = qmc_hdlc_probe, .probe = qmc_hdlc_probe,
.remove = qmc_hdlc_remove, .remove_new = qmc_hdlc_remove,
}; };
module_platform_driver(qmc_hdlc_driver); module_platform_driver(qmc_hdlc_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment