Commit 09775c85 authored by David Brownell's avatar David Brownell Committed by Linus Torvalds

[PATCH] reduce ext3 log spamming (blank lines)

When drives go offline, e.g.  usb-storage disconnect, the upper layers
don't behave very intelligently yet: ext3 over scsi keeps retrying reads,
logging three lines for each error:

10:58:31  scsi0 (0:0): rejecting I/O to dead device
10:58:31  EXT3-fs error (device sda1): ext3_find_entry: reading directory #18089296 offset 0
10:58:31 
10:59:47  EXT3-fs error (device sda1): ext3_find_entry: reading directory #18089296 offset 0

This patch shrinks that log spam by the trivial third, getting rid of those
needless blank lines.  It's not clear to me why the "no such device" errors
don't immediately make ext3 (or is it the block layer?) give up ...  maybe
someone else can make Linux not retry after those errors.
Signed-off-by: default avatarDavid Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 9f5354ec
...@@ -872,7 +872,7 @@ static struct buffer_head * ext3_find_entry (struct dentry *dentry, ...@@ -872,7 +872,7 @@ static struct buffer_head * ext3_find_entry (struct dentry *dentry,
if (!buffer_uptodate(bh)) { if (!buffer_uptodate(bh)) {
/* read error, skip block & hope for the best */ /* read error, skip block & hope for the best */
ext3_error(sb, __FUNCTION__, "reading directory #%lu " ext3_error(sb, __FUNCTION__, "reading directory #%lu "
"offset %lu\n", dir->i_ino, block); "offset %lu", dir->i_ino, block);
brelse(bh); brelse(bh);
goto next; goto next;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment