Commit 0d0336cf authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman Committed by Jason Gunthorpe

infiniband: qib: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent e7751180
...@@ -66,15 +66,6 @@ static const struct file_operations _##name##_file_ops = { \ ...@@ -66,15 +66,6 @@ static const struct file_operations _##name##_file_ops = { \
.release = seq_release \ .release = seq_release \
}; };
#define DEBUGFS_FILE_CREATE(name) \
do { \
struct dentry *ent; \
ent = debugfs_create_file(#name , 0400, ibd->qib_ibdev_dbg, \
ibd, &_##name##_file_ops); \
if (!ent) \
pr_warn("create of " #name " failed\n"); \
} while (0)
static void *_opcode_stats_seq_start(struct seq_file *s, loff_t *pos) static void *_opcode_stats_seq_start(struct seq_file *s, loff_t *pos)
{ {
struct qib_opcode_stats_perctx *opstats; struct qib_opcode_stats_perctx *opstats;
...@@ -249,17 +240,17 @@ DEBUGFS_FILE(qp_stats) ...@@ -249,17 +240,17 @@ DEBUGFS_FILE(qp_stats)
void qib_dbg_ibdev_init(struct qib_ibdev *ibd) void qib_dbg_ibdev_init(struct qib_ibdev *ibd)
{ {
struct dentry *root;
char name[10]; char name[10];
snprintf(name, sizeof(name), "qib%d", dd_from_dev(ibd)->unit); snprintf(name, sizeof(name), "qib%d", dd_from_dev(ibd)->unit);
ibd->qib_ibdev_dbg = debugfs_create_dir(name, qib_dbg_root); root = debugfs_create_dir(name, qib_dbg_root);
if (!ibd->qib_ibdev_dbg) { ibd->qib_ibdev_dbg = root;
pr_warn("create of %s failed\n", name);
return; debugfs_create_file("opcode_stats", 0400, root, ibd,
} &_opcode_stats_file_ops);
DEBUGFS_FILE_CREATE(opcode_stats); debugfs_create_file("ctx_stats", 0400, root, ibd, &_ctx_stats_file_ops);
DEBUGFS_FILE_CREATE(ctx_stats); debugfs_create_file("qp_stats", 0400, root, ibd, &_qp_stats_file_ops);
DEBUGFS_FILE_CREATE(qp_stats);
} }
void qib_dbg_ibdev_exit(struct qib_ibdev *ibd) void qib_dbg_ibdev_exit(struct qib_ibdev *ibd)
...@@ -274,8 +265,6 @@ void qib_dbg_ibdev_exit(struct qib_ibdev *ibd) ...@@ -274,8 +265,6 @@ void qib_dbg_ibdev_exit(struct qib_ibdev *ibd)
void qib_dbg_init(void) void qib_dbg_init(void)
{ {
qib_dbg_root = debugfs_create_dir(QIB_DRV_NAME, NULL); qib_dbg_root = debugfs_create_dir(QIB_DRV_NAME, NULL);
if (!qib_dbg_root)
pr_warn("init of debugfs failed\n");
} }
void qib_dbg_exit(void) void qib_dbg_exit(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment